[alsa-devel] [PATCH 1/3] ALSA: hda: do not override bus codec_mask in link_get()

Takashi Iwai tiwai at suse.de
Fri Feb 7 09:21:20 CET 2020


On Thu, 06 Feb 2020 21:02:21 +0100,
Kai Vehmanen wrote:
> 
> snd_hdac_ext_bus_link_get() does not work correctly in case
> there are multiple codecs on the bus. It unconditionally
> resets the bus->codec_mask value. As per documentation in
> hdaudio.h and existing use in client code, this field should
> be used to store bit flag of detected codecs on the bus.
> 
> By overwriting value of the codec_mask, information on all
> detected codecs is lost. No current user of hdac is impacted,
> but use of bus->codec_mask is planned in future patches
> for SOF.
> 
> Signed-off-by: Kai Vehmanen <kai.vehmanen at linux.intel.com>
> Reviewed-by: Ranjani Sridharan <ranjani.sridharan at linux.intel.com>
> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>

Reviewed-by: Takashi Iwai <tiwai at suse.de>

Mark, feel free to take this fix together with other two.


thanks,

Takashi


More information about the Alsa-devel mailing list