[PATCH 4/9] confmisc: fix memory leak in snd_func_concat

[Takashi Iwai]

On Sat, 26 Dec 2020 22:35:42 +0100,
Alex Henrie wrote:
> 
> Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
> ---
>  src/confmisc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/confmisc.c b/src/confmisc.c
> index eb8218c1..aece39c3 100644
> --- a/src/confmisc.c
> +++ b/src/confmisc.c
> @@ -440,8 +440,8 @@ int snd_func_concat(snd_config_t **dst, snd_config_t *root, snd_config_t *src,
>  	err = snd_config_get_id(src, &id);
>  	if (err >= 0)
>  		err = snd_config_imake_string(dst, id, res);
> -	free(res);
>        __error:
> +	free(res);
>  	return err;
>  }
>  #ifndef DOC_HIDDEN

I guess this would lead to the double-free at the error path after
realloc() that already freed res before the goto line.
Care to fix it and resubmit this one?


thanks,

Takashi