[PATCH] ASoC: Intel: fix error code cnl_set_dsp_D0()

Rojewski, Cezary cezary.rojewski at intel.com
Mon Dec 14 10:08:44 CET 2020


On 2020-12-11 11:06 AM, Dan Carpenter wrote:
> Return -ETIMEDOUT if the dsp boot times out instead of returning
> success.
> 
> Fixes: cb6a55284629 ("ASoC: Intel: cnl: Add sst library functions for cnl platform")
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> ---
> Not tested.
> 
>   sound/soc/intel/skylake/cnl-sst.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/intel/skylake/cnl-sst.c b/sound/soc/intel/skylake/cnl-sst.c
> index fcd8dff27ae8..1275c149acc0 100644
> --- a/sound/soc/intel/skylake/cnl-sst.c
> +++ b/sound/soc/intel/skylake/cnl-sst.c
> @@ -224,6 +224,7 @@ static int cnl_set_dsp_D0(struct sst_dsp *ctx, unsigned int core_id)
>   				"dsp boot timeout, status=%#x error=%#x\n",
>   				sst_dsp_shim_read(ctx, CNL_ADSP_FW_STATUS),
>   				sst_dsp_shim_read(ctx, CNL_ADSP_ERROR_CODE));
> +			ret = -ETIMEDOUT;
>   			goto err;
>   		}
>   	} else {
> 

Thanks for the patch, Dan.

Reviewed-by: Cezary Rojewski <cezary.rojewski at intel.com>



More information about the Alsa-devel mailing list