AMD ACP raven ridge: invalid audio mode 2

[Mukunda,Vijendar]

On 08/12/20 8:34 pm, Takashi Iwai wrote:
> Adding AMD people to Cc.
> 
> On Tue, 08 Dec 2020 15:01:24 +0100,
> Janpieter Sollie wrote:
>>
>> Forwarded from: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D208699&data=04%7C01%7CVijendar.Mukunda%40amd.com%7Cc55d2e5a7fc8472e14ce08d89b8a9a5e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C1%7C637430367345025555%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=LnNjfKSgSFcozSegpZ52afwMtmK%2FE5AbcHwn0r49jdY%3D&reserved=0
>>
>> Anybody who knows what this "ACP" actually does? what's its use?

ACP(Audio Co-processor) is an AMD Audio IP which has multiple 
generations support(1.x,2.x,3.x..etc)

ACP supports different audio configurations like I2S/AZ etc.. endpoint 
support.
Based on the platform, Audio configuration will be programmed from BIOS.
For example, to use I2S endpoint ACP_I2S_PIN_CONFIG is programmed as 
0x04 on Raven Ridge.
To use the AZ(HD AUdio) endpoint, ACP_I2S_PIN_CONFIG is programmed to 
different value.

On Raven ridge APU, We have upstreamed ACP PCI driver and I2S ASoC driver.

On Renoir APU, We have upstreamed ACP PCI driver along with PDM DMA 
driver. You have to enable ACP specific Kconfig flags for renoir 
platform when platform has DMIC support and it is connected to APU.

I see from the logs, you have tried to load ACP PDM DMIC driver but 
attached config file is not matching.

There are hardware differences in terms of ACP IP for both Raven and Renoir.

HD Audio endpoint uses open source HDA driver.

Let us know what is your platform configuration?
What Audio endpoints your platform supports?

--
Vijendar




>>
>>
>> Kind regards,
>>
>>
>> Janpieter Sollie
>>