[RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2
Marek Szyprowski
m.szyprowski at samsung.com
Mon Aug 31 14:50:25 CEST 2020
Hi Krzysztof,
On 29.08.2020 16:25, Krzysztof Kozlowski wrote:
> The USB-C connector bindings require port at 0. Such port was already
> described in DTS but outside of the connector itself. Put it into
> proper place to fix dtbs_check warnings like:
>
> arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: musb_connector: ports: 'port at 0' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzk at kernel.org>
I'm not sure if topic should be about USB-C, I will call it simply USB
connector node. TM2(e) uses Samsung's 11-pin micro USB 2.0 connector,
which has nothing in common with USB Type-C.
Anyway, this patch breaks DWC3 (tested in Device mode) driver operation,
so something has to be somehow adjusted or fixed. Added CC Andrzej
Hajda, who actually worked on this.
> ---
>
> Not tested on HQ. Please kindly review and test.
>
> Best regards,
> Krzysztof
> ---
> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index 6246cce2a15e..bab6c1addd5f 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -871,6 +871,13 @@
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port at 0 {
> + reg = <0>;
> + muic_to_usb: endpoint {
> + remote-endpoint = <&usb_to_muic>;
> + };
> + };
> +
> port at 3 {
> reg = <3>;
> musb_con_to_mhl: endpoint {
> @@ -879,14 +886,6 @@
> };
> };
> };
> -
> - ports {
> - port {
> - muic_to_usb: endpoint {
> - remote-endpoint = <&usb_to_muic>;
> - };
> - };
> - };
> };
>
> regulators {
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
More information about the Alsa-devel
mailing list