[PATCH v2] ALSA: HDA: Early Forbid of runtime PM

[Takashi Iwai]

On Fri, 28 Aug 2020 19:06:51 +0200,
Jillela, Emmanuel wrote:
> 
> 
> > Subject: Re: [PATCH v2] ALSA: HDA: Early Forbid of runtime PM
> > 
> > Hey,
> > 
> > On Fri, 28 Aug 2020, Takashi Iwai wrote:
> > 
> > > On Fri, 28 Aug 2020 01:05:36 +0200, Harsha Priya wrote:
> > > > This issue being common across all codecs, pm_runtime_forbid() is
> > > > called when the codec object is created to fix this issue.
> > > > A codec enables or disables runtime pm in its own probe function.
> > >
> > > Thanks.  The only concern is about the influence on the relevant ASoC
> > > code, especially hdac_hda.c.
> > >
> > > Kai, could you check whether this still works?
> > 
> > I believe Harsha is testing mostly with ASoC, so hdac_hda.c should be covered.
> > 
> > I did queue a SOF CI job for this v2 patch and I'm seeing some failures in module
> > load/unload test that might be related and need checking before we merge:
> > 
> > https://sof-ci.01.org/linuxpr/PR2403/build4400/devicetest/
> > 
> > The actual runtime-PM tests in our test set pass, but module load/unload has failures >on
> > some platforms. I'll follow-up when I have a better understanding what goes wrong.
> > 
> > Br, Kai
> I am just trying to think ahead to get something that may work. We can add an if check around the pm_runtime_forbid like below
> If (!codec->auto_runtime_pm)
> 	Pm_runtime_forbid(&codec->core.dev)
> Do you think that will work??

snd_hda_codec_device_new() is called before setting the flag, so it's
no use for adding the conditional.


thanks,

Takashi