[PATCH 1/9] soundwire: define and use addr bit masks

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Fri Aug 28 18:03:09 CEST 2020


Hi Vinod,
This change to use FIELD_PREP/GET looks good, the code is indeed a lot 
clearer, but ...

> +#define SDW_DISCO_LINK_ID(adr)	FIELD_GET(SDW_DISCO_LINK_ID_MASK, addr)
> +#define SDW_VERSION(adr)	FIELD_GET(SDW_VERSION_MASK, addr)
> +#define SDW_UNIQUE_ID(adr)	FIELD_GET(SDW_UNIQUE_ID_MASK, addr)
> +#define SDW_MFG_ID(adr)		FIELD_GET(SDW_MFG_ID_MASK, addr)
> +#define SDW_PART_ID(adr)	FIELD_GET(SDW_PART_ID_MASK, addr)
> +#define SDW_CLASS_ID(adr)	FIELD_GET(SDW_CLASS_ID_MASK, addr)

...our CI stopped on a compilation error with these macros. You will 
need the patch1 attached.

Patch 9 also introduces conflicts with the multi-link code (fix in 
patch2), so would you mind if we go first with the multi-link code, or 
defer patch9 for now?

Our validation for CML w/ RT700 is at:
https://github.com/thesofproject/linux/pull/2404

We will also test on machines that are not in the CI farm and provide 
feedback.

Thanks
-Pierre

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fixup-soundwire-define-and-use-addr-bit-masks.patch
Type: text/x-patch
Size: 1576 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20200828/b639aee1/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-soundwire-intel-use-FIELD_PREP-macro.patch
Type: text/x-patch
Size: 1729 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20200828/b639aee1/attachment-0003.bin>


More information about the Alsa-devel mailing list