[PATCH 4/4] ASoC: rt715: Fix return check for devm_regmap_init_sdw()
Vinod Koul
vkoul at kernel.org
Wed Aug 26 18:21:01 CEST 2020
On 26-08-20, 10:09, Pierre-Louis Bossart wrote:
>
>
> On 8/26/20 7:28 AM, Vinod Koul wrote:
> > devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on
> > failure which should be checked with IS_ERR. Also use PTR_ERR for
> > returning error codes.
>
> Do you mind changing these two additional codecs that were missed in this
> series? Thanks!
>
> rt700-sdw.c: sdw_regmap = devm_regmap_init_sdw(slave, &rt700_sdw_regmap);
> rt700-sdw.c- if (!sdw_regmap)
> rt700-sdw.c- return -EINVAL;
Yes missed this one
>
> --
> rt711-sdw.c: sdw_regmap = devm_regmap_init_sdw(slave, &rt711_sdw_regmap);
> rt711-sdw.c- if (!sdw_regmap)
> rt711-sdw.c- return -EINVAL;
And somehow patch series is messed, I have two 2/4 but no 3/4 which
patches rt711-sdw.c, will send v2 with these fixed
--
~Vinod
More information about the Alsa-devel
mailing list