[PATCH 03/20] ALSA: hda/ca0132 - Add surround channel config control.

[Takashi Iwai]

On Fri, 21 Aug 2020 20:52:20 +0200,
Connor McAdams wrote:
> 
> +static int ca0132_alt_add_speaker_channel_cfg_enum(struct hda_codec *codec)
> +{
> +	struct snd_kcontrol_new knew =
> +		HDA_CODEC_MUTE_MONO("Output: Channels",
> +				    SPEAKER_CHANNEL_CFG_ENUM, 1, 0, HDA_OUTPUT);

This isn't good as a control element name.  It's not only specific
about the purpose, also the use of a letter like ':' may confuse the
user-space tools.  Please choose a different name like "Surround
Channel Mode", "Surround Channel Config" or such one.


thanks,

Takashi