[PATCH] ASoC: Intel: skl_hda_dsp_generic: Fix NULLptr dereference in autosuspend delay

Kai Vehmanen kai.vehmanen at linux.intel.com
Mon Aug 17 18:35:56 CEST 2020


Hi,

On Mon, 17 Aug 2020, Gorski, Mateusz wrote:

> W dniu 8/12/2020 o 3:48 PM, Kai Vehmanen pisze:
> > So what we really want to do is to confirm the codec driver is hdac_hda
> > (and not hdac_hdmi or any other drivers), and if yes, then call the
> > autosuspend function. I did spend some time trying to find a clean(er) way
> > to do this, but codec name seemed the best option. I'll test the hdmi-only
> > case, but I believe Mateusz patch will work in that case as well.
> 
> is there anything else I can do with this patch?

I today tested the patch on systems with only HDMI and it does the right 
thing as expected. I also took another look at ways to more cleanly 
separate between hdac-hdmi and hdac-hda here, but so far nothing cleaner. 
As this is fixing a clear regression, I'll give my:

Reviewed-by: Kai Vehmanen <kai.vehmanen at linux.intel.com>

Br, Kai


More information about the Alsa-devel mailing list