[PATCH RFC] ASoC: wm8994: Avoid attempts to read unreadable registers

Charles Keepax ckeepax at opensource.cirrus.com
Mon Aug 17 11:25:05 CEST 2020


On Fri, Jul 31, 2020 at 07:38:34PM +0200, Sylwester Nawrocki wrote:
> The driver supports WM1811, WM8994, WM8958 devices but according to
> documentation and the regmap definitions the WM8958_DSP2_* registers
> are only available on WM8958. In current code these registers are
> being accessed as if they were available on all the three chips.
> 
> When starting playback on WM1811 CODEC multiple errors like:
> "wm8994-codec wm8994-codec: ASoC: error at soc_component_read_no_lock on wm8994-codec: -5"
> can be seen, which is caused by attempts to read an unavailable
> WM8958_DSP2_PROGRAM register. The issue has been uncovered by recent
> commit "e2329ee ASoC: soc-component: add soc_component_err()".
> 
> This patch adds a check in wm8958_aif_ev() callback so the DSP2 handling
> is only done for WM8958.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki at samsung.com>
> ---

Sorry for the delay.

Acked-by: Charles Keepax <ckeepax at opensource.cirrus.com>

Thanks,
Charles


More information about the Alsa-devel mailing list