[PATCH v2 09/13] ASoC: Intel: Select catpt and deprecate haswell

kernel test robot lkp at intel.com
Tue Aug 11 15:08:43 CEST 2020


Hi Cezary,

I love your patch! Perhaps something to improve:

[auto build test WARNING on asoc/for-next]
[also build test WARNING on sound/for-next v5.8 next-20200811]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Cezary-Rojewski/ASoC-Intel-Catpt-Lynx-and-Wildcat-point/20200811-181319
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:404,
                    from include/linux/kernel.h:15,
                    from arch/x86/include/asm/percpu.h:45,
                    from arch/x86/include/asm/current.h:6,
                    from include/linux/sched.h:12,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from include/linux/dma-mapping.h:7,
                    from sound/soc/intel/catpt/loader.c:8:
   sound/soc/intel/catpt/loader.c: In function 'catpt_restore_fwimage':
>> sound/soc/intel/catpt/loader.c:277:22: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
     277 |   dev_dbg(cdev->dev, "found intersecting region: 0x%08llx-%08llx\n",
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:125:15: note: in definition of macro '__dynamic_func_call'
     125 |   func(&id, ##__VA_ARGS__);  \
         |               ^~~~~~~~~~~
   include/linux/dynamic_debug.h:157:2: note: in expansion of macro '_dynamic_func_call'
     157 |  _dynamic_func_call(fmt,__dynamic_dev_dbg,   \
         |  ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:115:2: note: in expansion of macro 'dynamic_dev_dbg'
     115 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |  ^~~~~~~~~~~~~~~
   include/linux/dev_printk.h:115:23: note: in expansion of macro 'dev_fmt'
     115 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                       ^~~~~~~
   sound/soc/intel/catpt/loader.c:277:3: note: in expansion of macro 'dev_dbg'
     277 |   dev_dbg(cdev->dev, "found intersecting region: 0x%08llx-%08llx\n",
         |   ^~~~~~~
   sound/soc/intel/catpt/loader.c:277:57: note: format string is defined here
     277 |   dev_dbg(cdev->dev, "found intersecting region: 0x%08llx-%08llx\n",
         |                                                    ~~~~~^
         |                                                         |
         |                                                         long long unsigned int
         |                                                    %08x
   In file included from include/linux/printk.h:404,
                    from include/linux/kernel.h:15,
                    from arch/x86/include/asm/percpu.h:45,
                    from arch/x86/include/asm/current.h:6,
                    from include/linux/sched.h:12,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from include/linux/dma-mapping.h:7,
                    from sound/soc/intel/catpt/loader.c:8:
   sound/soc/intel/catpt/loader.c:277:22: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
     277 |   dev_dbg(cdev->dev, "found intersecting region: 0x%08llx-%08llx\n",
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:125:15: note: in definition of macro '__dynamic_func_call'
     125 |   func(&id, ##__VA_ARGS__);  \
         |               ^~~~~~~~~~~
   include/linux/dynamic_debug.h:157:2: note: in expansion of macro '_dynamic_func_call'
     157 |  _dynamic_func_call(fmt,__dynamic_dev_dbg,   \
         |  ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:115:2: note: in expansion of macro 'dynamic_dev_dbg'
     115 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |  ^~~~~~~~~~~~~~~
   include/linux/dev_printk.h:115:23: note: in expansion of macro 'dev_fmt'
     115 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                       ^~~~~~~
   sound/soc/intel/catpt/loader.c:277:3: note: in expansion of macro 'dev_dbg'
     277 |   dev_dbg(cdev->dev, "found intersecting region: 0x%08llx-%08llx\n",
         |   ^~~~~~~
   sound/soc/intel/catpt/loader.c:277:64: note: format string is defined here
     277 |   dev_dbg(cdev->dev, "found intersecting region: 0x%08llx-%08llx\n",
         |                                                           ~~~~~^
         |                                                                |
         |                                                                long long unsigned int
         |                                                           %08x
   In file included from include/linux/printk.h:404,
                    from include/linux/kernel.h:15,
                    from arch/x86/include/asm/percpu.h:45,
                    from arch/x86/include/asm/current.h:6,
                    from include/linux/sched.h:12,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from include/linux/dma-mapping.h:7,
                    from sound/soc/intel/catpt/loader.c:8:
   sound/soc/intel/catpt/loader.c:279:22: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
     279 |   dev_dbg(cdev->dev, "restoring fwimage: start 0x%08llx size %lld\n",
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:125:15: note: in definition of macro '__dynamic_func_call'
     125 |   func(&id, ##__VA_ARGS__);  \
         |               ^~~~~~~~~~~
   include/linux/dynamic_debug.h:157:2: note: in expansion of macro '_dynamic_func_call'
     157 |  _dynamic_func_call(fmt,__dynamic_dev_dbg,   \
         |  ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:115:2: note: in expansion of macro 'dynamic_dev_dbg'
     115 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |  ^~~~~~~~~~~~~~~
   include/linux/dev_printk.h:115:23: note: in expansion of macro 'dev_fmt'
     115 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                       ^~~~~~~
   sound/soc/intel/catpt/loader.c:279:3: note: in expansion of macro 'dev_dbg'
     279 |   dev_dbg(cdev->dev, "restoring fwimage: start 0x%08llx size %lld\n",
         |   ^~~~~~~
   sound/soc/intel/catpt/loader.c:279:55: note: format string is defined here
     279 |   dev_dbg(cdev->dev, "restoring fwimage: start 0x%08llx size %lld\n",
         |                                                  ~~~~~^
         |                                                       |
         |                                                       long long unsigned int
         |                                                  %08x
   In file included from include/linux/printk.h:404,
                    from include/linux/kernel.h:15,
                    from arch/x86/include/asm/percpu.h:45,
                    from arch/x86/include/asm/current.h:6,
                    from include/linux/sched.h:12,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from include/linux/dma-mapping.h:7,
                    from sound/soc/intel/catpt/loader.c:8:
>> sound/soc/intel/catpt/loader.c:279:22: warning: format '%lld' expects argument of type 'long long int', but argument 5 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
     279 |   dev_dbg(cdev->dev, "restoring fwimage: start 0x%08llx size %lld\n",
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:125:15: note: in definition of macro '__dynamic_func_call'
     125 |   func(&id, ##__VA_ARGS__);  \
         |               ^~~~~~~~~~~
   include/linux/dynamic_debug.h:157:2: note: in expansion of macro '_dynamic_func_call'
     157 |  _dynamic_func_call(fmt,__dynamic_dev_dbg,   \
         |  ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:115:2: note: in expansion of macro 'dynamic_dev_dbg'
     115 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |  ^~~~~~~~~~~~~~~
   include/linux/dev_printk.h:115:23: note: in expansion of macro 'dev_fmt'
     115 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                       ^~~~~~~
   sound/soc/intel/catpt/loader.c:279:3: note: in expansion of macro 'dev_dbg'
     279 |   dev_dbg(cdev->dev, "restoring fwimage: start 0x%08llx size %lld\n",
         |   ^~~~~~~
   sound/soc/intel/catpt/loader.c:279:65: note: format string is defined here
     279 |   dev_dbg(cdev->dev, "restoring fwimage: start 0x%08llx size %lld\n",
         |                                                              ~~~^
         |                                                                 |
         |                                                                 long long int
         |                                                              %d

vim +277 sound/soc/intel/catpt/loader.c

2305f5477ad095 Cezary Rojewski 2020-08-11  239  
2305f5477ad095 Cezary Rojewski 2020-08-11  240  static int catpt_restore_fwimage(struct catpt_dev *cdev,
2305f5477ad095 Cezary Rojewski 2020-08-11  241  				 struct dma_chan *chan, dma_addr_t paddr,
2305f5477ad095 Cezary Rojewski 2020-08-11  242  				 struct catpt_fw_block_hdr *blk)
2305f5477ad095 Cezary Rojewski 2020-08-11  243  {
2305f5477ad095 Cezary Rojewski 2020-08-11  244  	struct resource r1, r2, common;
2305f5477ad095 Cezary Rojewski 2020-08-11  245  	int i;
2305f5477ad095 Cezary Rojewski 2020-08-11  246  
2305f5477ad095 Cezary Rojewski 2020-08-11  247  	print_hex_dump_debug(__func__, DUMP_PREFIX_OFFSET, 8, 4,
2305f5477ad095 Cezary Rojewski 2020-08-11  248  			     blk, sizeof(*blk), false);
2305f5477ad095 Cezary Rojewski 2020-08-11  249  
2305f5477ad095 Cezary Rojewski 2020-08-11  250  	r1.start = cdev->dram.start + blk->ram_offset;
2305f5477ad095 Cezary Rojewski 2020-08-11  251  	r1.end = r1.start + blk->size - 1;
2305f5477ad095 Cezary Rojewski 2020-08-11  252  	/* advance to data area */
2305f5477ad095 Cezary Rojewski 2020-08-11  253  	paddr += sizeof(*blk);
2305f5477ad095 Cezary Rojewski 2020-08-11  254  
2305f5477ad095 Cezary Rojewski 2020-08-11  255  	for (i = 0; i < cdev->dx_ctx.num_meminfo; i++) {
2305f5477ad095 Cezary Rojewski 2020-08-11  256  		struct catpt_save_meminfo *info;
2305f5477ad095 Cezary Rojewski 2020-08-11  257  		u32 off;
2305f5477ad095 Cezary Rojewski 2020-08-11  258  		int ret;
2305f5477ad095 Cezary Rojewski 2020-08-11  259  
2305f5477ad095 Cezary Rojewski 2020-08-11  260  		info = &cdev->dx_ctx.meminfo[i];
2305f5477ad095 Cezary Rojewski 2020-08-11  261  
2305f5477ad095 Cezary Rojewski 2020-08-11  262  		if (info->source != CATPT_DX_TYPE_FW_IMAGE)
2305f5477ad095 Cezary Rojewski 2020-08-11  263  			continue;
2305f5477ad095 Cezary Rojewski 2020-08-11  264  
2305f5477ad095 Cezary Rojewski 2020-08-11  265  		off = catpt_to_host_offset(info->offset);
2305f5477ad095 Cezary Rojewski 2020-08-11  266  		if (off < cdev->dram.start || off > cdev->dram.end)
2305f5477ad095 Cezary Rojewski 2020-08-11  267  			continue;
2305f5477ad095 Cezary Rojewski 2020-08-11  268  
2305f5477ad095 Cezary Rojewski 2020-08-11  269  		r2.start = off;
2305f5477ad095 Cezary Rojewski 2020-08-11  270  		r2.end = r2.start + info->size - 1;
2305f5477ad095 Cezary Rojewski 2020-08-11  271  
2305f5477ad095 Cezary Rojewski 2020-08-11  272  		if (!catpt_resource_overlapping(&r2, &r1, &common))
2305f5477ad095 Cezary Rojewski 2020-08-11  273  			continue;
2305f5477ad095 Cezary Rojewski 2020-08-11  274  		/* calculate start offset of common data area */
2305f5477ad095 Cezary Rojewski 2020-08-11  275  		off = common.start - r1.start;
2305f5477ad095 Cezary Rojewski 2020-08-11  276  
2305f5477ad095 Cezary Rojewski 2020-08-11 @277  		dev_dbg(cdev->dev, "found intersecting region: 0x%08llx-%08llx\n",
2305f5477ad095 Cezary Rojewski 2020-08-11  278  			common.start, common.end);
2305f5477ad095 Cezary Rojewski 2020-08-11 @279  		dev_dbg(cdev->dev, "restoring fwimage: start 0x%08llx size %lld\n",
2305f5477ad095 Cezary Rojewski 2020-08-11  280  			common.start, resource_size(&common));
2305f5477ad095 Cezary Rojewski 2020-08-11  281  
2305f5477ad095 Cezary Rojewski 2020-08-11  282  		ret = catpt_dma_memcpy_todsp(cdev, chan, common.start,
2305f5477ad095 Cezary Rojewski 2020-08-11  283  					     paddr + off,
2305f5477ad095 Cezary Rojewski 2020-08-11  284  					     resource_size(&common));
2305f5477ad095 Cezary Rojewski 2020-08-11  285  		if (ret < 0) {
2305f5477ad095 Cezary Rojewski 2020-08-11  286  			dev_err(cdev->dev, "memcpy todsp failed: %d\n", ret);
2305f5477ad095 Cezary Rojewski 2020-08-11  287  			return ret;
2305f5477ad095 Cezary Rojewski 2020-08-11  288  		}
2305f5477ad095 Cezary Rojewski 2020-08-11  289  	}
2305f5477ad095 Cezary Rojewski 2020-08-11  290  
2305f5477ad095 Cezary Rojewski 2020-08-11  291  	return 0;
2305f5477ad095 Cezary Rojewski 2020-08-11  292  }
2305f5477ad095 Cezary Rojewski 2020-08-11  293  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 74191 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20200811/b50fe5d3/attachment-0001.gz>


More information about the Alsa-devel mailing list