[PATCH] ALSA: hda - reverse the setting value in the micmute_led_set

Takashi Iwai tiwai at suse.de
Tue Aug 11 14:51:06 CEST 2020


On Tue, 11 Aug 2020 14:24:30 +0200,
Hui Wang wrote:
> 
> Before the micmute_led_set() is introduced, the function of
> alc_gpio_micmute_update() will set the gpio value with the
> !micmute_led.led_value, and the machines have the correct micmute led
> status. After the micmute_led_set() is introduced, it sets the gpio
> value with !!micmute_led.led_value, so the led status is not correct
> anymore, we need to set micmute_led_polarity = 1 to workaround it.
> 
> Now we fix the micmute_led_set() and remove micmute_led_polarity = 1.
> 
> Fixes: 87dc36482cab ("ALSA: hda/realtek - Add LED class support for micmute LED")
> Reported-and-suggested-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
> Cc: <stable at vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang at canonical.com>

Thanks, applied.


Takashi


More information about the Alsa-devel mailing list