[PATCH v2 01/13] ASoC: Intel: Add catpt device

Amadeusz Sławiński amadeuszx.slawinski at linux.intel.com
Tue Aug 11 14:17:08 CEST 2020



On 8/11/2020 12:00 PM, Cezary Rojewski wrote:
> Declare base structures, registers and device routines for the catpt
> solution. Catpt deprecates and is a direct replacement for
> sound/soc/intel/haswell. Supports Lynxpoint and Wildcat Point both.
> 
> Signed-off-by: Cezary Rojewski <cezary.rojewski at intel.com>
> ---

...

> diff --git a/sound/soc/intel/catpt/registers.h b/sound/soc/intel/catpt/registers.h
> new file mode 100644
> index 000000000000..62c968a4721a
> --- /dev/null
> +++ b/sound/soc/intel/catpt/registers.h
> @@ -0,0 +1,191 @@
> +/* SPDX-License-Identifier: GPL-2.0-only

If we are making sure that SPDX headers are correct, from what I 
remember SPDX identifier should be a separate comment line, even if 
followed by comment. Checkpatch doesn't seem to care and I can't find 
anything explicitly saying that's a rule in 
Documentation/process/license-rules.rst (apart from one line "C Header" 
example, which is one line comment). Can someone else chime in? Also all 
other header that are included in patchset seem to follow this scheme...

> + *
> + * Copyright(c) 2020 Intel Corporation. All rights reserved.
> + *
> + * Author: Cezary Rojewski <cezary.rojewski at intel.com>
> + */
> +


More information about the Alsa-devel mailing list