[PATCH] ASoC: Make soc_component_read() returning an error code again

[Mark Brown]

On Mon, Aug 10, 2020 at 09:45:14PM -0700, John Stultz wrote:
> On Mon, Aug 10, 2020 at 6:53 AM Takashi Iwai <tiwai at suse.de> wrote:

> >         if (ret < 0)
> > -               soc_component_ret(component, ret);
> > +               return soc_component_ret(component, ret);

> So oddly, using this instead of just "return ret;", doesn't seem to
> fully resolve the issue for me. It's baffling!

> My only guess is at boot up I get a *ton* of error messages:
>   q6routing remoteproc-adsp:glink-edge:apr:apr-service at 8:routing:
> ASoC: error at soc_component_read_no_lock on
> remoteproc-adsp:glink-edge:apr:5
> which I suspect is causing other failures due to timing issues.

Seems likely.

> Srini sent me a patch to provide dummy read functions for the routing
> and dai components that were missing it, and that seems to properly
> avoid the issue.

Hopefully Srini will post that soon then.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20200811/3ef6dc19/attachment.sig>