[PATCH] ALSA: hda - fix the micmute led status for Lenovo ThinkCentre AIO

[Takashi Iwai]

On Mon, 10 Aug 2020 04:16:59 +0200,
Hui Wang wrote:
> 
> After installing the Ubuntu Linux, the micmute led status is not
> correct. Users expect that the led is on if the capture is disabled,
> but with the current kernel, the led is off with the capture disabled.
> 
> We tried the old linux kernel like linux-4.15, there is no this issue.
> It looks like we introduced this issue when switching to the led_cdev.

The behavior can be controlled via "Mic Mute-LED Mode" enum kcontrol.
Which value does it have now?  If it's "Follow Capture", that's the
correct behavior.  OTOH, if it's "Follow Mute", the LED polarity is
indeed wrong.


thanks,

Takashi


> 
> Cc: <stable at vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang at canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index daedcc0adc21..09d93dd88713 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4414,6 +4414,7 @@ static void alc233_fixup_lenovo_line2_mic_hotkey(struct hda_codec *codec,
>  {
>  	struct alc_spec *spec = codec->spec;
>  
> +	spec->micmute_led_polarity = 1;
>  	alc_fixup_hp_gpio_led(codec, action, 0, 0x04);
>  	if (action == HDA_FIXUP_ACT_PRE_PROBE) {
>  		spec->init_amp = ALC_INIT_DEFAULT;
> -- 
> 2.17.1
>