Creative USB X-Fi Pro V3 volume knob and IR remote control

[_]

Hi,

I hope I'm in the right place here.

I bought a Creative USB X-Fi Pro (external USB DAC) which
plays/records audio just fine out of the box. It
features a volume knob and also an IR remote control (RM-820). These
controls didn't work.
I followed a guide which describes how to get the controls to work on
Linux using LIRC
alsa_usb driver (https://alsa.opensrc.org/Usb-audio under section
"Creative USB X-Fi Surround 5.1").

It turned out the method didn't work for my device (LIRC wouldn't
detect the IR device) so I did some digging
and found this patch
(https://github.com/torvalds/linux/commit/3dc8523fa7412e731441c01fb33f003eb3cfece1)
which enables the volume knob for the device. I noticed the USB ID is
041e:3237, while my device has 041e:3263.
My device is marketed as "CREATIVE Sound Blaster X-Fi Surround 5.1 Pro
v3" and only available since the
beginning of 2019. So, I assume it to be another revision of the same
hardware. The device model is SB1095.

I recompiled my kernel with the attached simple patch and the controls
including the IR remote are now
detected by LIRC and working.

I'd be happy if the change could be picked up if possible.

Thank you
Mirko

---
 sound/usb/mixer_quirks.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
index cec1cfd7edb7..199cdbfdc761 100644
--- a/sound/usb/mixer_quirks.c
+++ b/sound/usb/mixer_quirks.c
@@ -185,6 +185,7 @@ static const struct rc_config {
        { USB_ID(0x041e, 0x3042), 0, 1, 1, 1,  1,  0x000d }, /* Usb X-Fi S51 */
        { USB_ID(0x041e, 0x30df), 0, 1, 1, 1,  1,  0x000d }, /* Usb
X-Fi S51 Pro */
        { USB_ID(0x041e, 0x3237), 0, 1, 1, 1,  1,  0x000d }, /* Usb
X-Fi S51 Pro */
+       { USB_ID(0x041e, 0x3263), 0, 1, 1, 1,  1,  0x000d }, /* Usb
X-Fi S51 Pro */
        { USB_ID(0x041e, 0x3048), 2, 2, 6, 6,  2,  0x6e91 }, /*
Toshiba SB0500 */
 };

-- 
2.28.0