[PATCH] ASoC: SOF: Add missing dependency on IMX_SCU

Daniel Baluta daniel.baluta at gmail.com
Thu Apr 23 17:21:40 CEST 2020


This should no longer be a problem after the following patch is merged:

https://patchwork.kernel.org/patch/11395247/

Also, Pierre already fixed this in SOF tree like this:

https://github.com/thesofproject/linux/commit/5e3103aaf77fd5c985d717a5fe774fd2154e97aa
I think we should go with Pierre's version for now.

Pierre,

Will you send the fixes to Mark? Or should I send them?

Anyone,

What is the exact difference between 'depends on' and 'selects'. This
is a question I try
to clarify for myself for a while. And most important when to use one
or another?


On Thu, Apr 23, 2020 at 5:29 PM Mark Brown <broonie at kernel.org> wrote:
>
> This broke PowerPC allyesconfig.
>
> Reported-by: Stephen Rothwell <sfr at canb.auug.org.au>
> Signed-off-by: Mark Brown <broonie at kernel.org>
> ---
>  sound/soc/sof/imx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig
> index 5e0c68b12292..9a5ed1860e4e 100644
> --- a/sound/soc/sof/imx/Kconfig
> +++ b/sound/soc/sof/imx/Kconfig
> @@ -21,6 +21,7 @@ config SND_SOC_SOF_IMX_OF
>
>  config SND_SOC_SOF_IMX8_SUPPORT
>         bool "SOF support for i.MX8"
> +       depends on IMX_SCU
>         help
>           This adds support for Sound Open Firmware for NXP i.MX8 platforms
>           Say Y if you have such a device.
> --
> 2.20.1
>


More information about the Alsa-devel mailing list