[PATCH 05/17] ASoC: soc-dai: add snd_soc_pcm_dai_trigger()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Apr 23 03:44:29 CEST 2020


Hi Ranjani

Thank you for reviewing

> > From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> > 
> > We have 2 type of component functions
> > snd_soc_dai_xxx()     is focusing to dai itself,
> > snd_soc_pcm_dai_xxx() is focusing to rtd related dai.
> > 
> > Now we can update snd_soc_dai_trigger() to
> > snd_soc_pcm_dai_trigger(). This patch do it.
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> > ---
(snip)
> > -	for_each_rtd_dais(rtd, i, dai) {
> > -		ret = snd_soc_dai_trigger(dai, substream, cmd);
> > -		if (ret < 0)
> > -			return ret;
> > -	}
> > +	ret = snd_soc_pcm_dai_trigger(substream, cmd);
> > +	if (ret < 0)
> > +		return ret;
> >  
> >  	return 0;
> Maybe just "return snd_soc_pcm_dai_trigger(substream, cmd);" here?

Ohh, yes indeed.
Thank you. will fix in v2


Thank you for your help !!

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list