[PATCH] alsactl: avoid needless wakeups in monitor loop.

Takashi Sakamoto o-takashi at sakamocchi.jp
Sun Apr 12 04:19:06 CEST 2020


Hi,

On Mon, Oct 14, 2019 at 11:38:02PM -0500, Zev Weiss wrote:
> The timeout wasn't really being used for anything; disabling it should
> reduce idle energy consumption slightly.
> 
> Signed-off-by: Zev Weiss <zev at bewilderbeest.net>
> ---
>  alsactl/monitor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I overlooked it as well... It looks good to me.

Reviewed-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>
Tested-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>

> diff --git a/alsactl/monitor.c b/alsactl/monitor.c
> index 6b090e4f5c92..6d9328d899a4 100644
> --- a/alsactl/monitor.c
> +++ b/alsactl/monitor.c
> @@ -340,7 +340,7 @@ static int run_dispatcher(int epfd, int sigfd, int infd, struct list_head *srcs,
>  		int count;
>  		int i;
>  
> -		count = epoll_wait(epfd, epev, max_ev_count, 200);
> +		count = epoll_wait(epfd, epev, max_ev_count, -1);
>  		if (count < 0) {
>  			err = count;
>  			break;
> -- 
> 2.23.0

Regards

Takashi Sakamoto


More information about the Alsa-devel mailing list