[alsa-devel] [PATCH 1/2] ASoC: Intel: boards: Add CML m/c using RT1011 and RT5682

[Pierre-Louis Bossart]

>> +static const struct snd_soc_dapm_route cml_rt1011_rt5682_map[] = {
>> +	/*speaker*/
>> +	{"TL Ext Spk", NULL, "TL SPO"},
>> +	{"TR Ext Spk", NULL, "TR SPO"},
>> +	{"WL Ext Spk", NULL, "WL SPO"},
>> +	{"WR Ext Spk", NULL, "WR SPO"},
>> +
>> +	/* HP jack connectors - unknown if we have jack detection */
>> +	{ "Headphone Jack", NULL, "HPOL" },
>> +	{ "Headphone Jack", NULL, "HPOR" },
>> +
>> +	/* other jacks */
>> +	{ "IN1P", NULL, "Headset Mic" },
>> +
>> +	/* DMIC */
>> +	{"DMic", NULL, "SoC DMIC"},
> 
> There is some inconsistent spacing around the braces.

Indeed, thanks for spotting this. checkpatch did not complain in the 
previous reviews.

>> +	for (i = 0; i < rtd->num_codecs; i++) {
>> +		codec_dai = rtd->codec_dais[i];
> 
> This looks like candidate for for_each_rtd_codec_dai macro


Good suggestion.

Sathya P, can you update this patch and send a v2? Thanks!