[alsa-devel] [PATCH v4 0/9] adapt SOF to use snd-hda-codec-hdmi

Takashi Iwai tiwai at suse.de
Mon Sep 16 21:36:53 CEST 2019


On Mon, 16 Sep 2019 17:59:06 +0200,
Pierre-Louis Bossart wrote:
> 
> On 9/12/19 9:21 AM, Kai Vehmanen wrote:
> > Hi all,
> >
> > here's the 4th round for this series that adapts SOF to use
> > snd-hda-codec-hdmi (patch_hdmi.c) codec driver instead of hdac_hdmi
> > (soc/codecs/hdac_hdmi.c). The primary goal is to unify the HDMI codec
> > implementation between DSP and non-DSP HDA configurations, offer same
> > interface to user-space and reduce maintenance load for all.
> 
> The series looks good to me so
> 
> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
> 
> I would recommend that we have a matching change for the Skylake
> driver and validation that both SOF and cAVS/SST drivers can operate
> with this mode set. Our goal is still to have coexistence between the
> two drivers in a single build/distro, e.g. cAVS for SKL/KBL/APL and
> SOF for newer platforms. This can be done in a follow-up patch but it
> needs to be done before distros start selecting this common HDMI mode.
> 
> The other concern I have is that we have other changes coming for
> soc-acpi and machine drivers to deal with SoundWire, so it'd be nice
> to have the changes mirrored between Mark and Takashi trees e.g. with
> the merge of a fixed branch.

In general it's already a bit too late to merge for 5.4, so the whole
series will be after that, at most, hence we still have enough time :)


Takashi


More information about the Alsa-devel mailing list