[alsa-devel] [PATCH 06/13] ASoC: soc-core: merge soc_free_pcm_runtime() and soc_rtd_free()
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Wed Sep 11 01:57:09 CEST 2019
Hi Sridharan
Thank you for your review.
> -static void soc_rtd_free(struct snd_soc_pcm_runtime *rtd)
> -{
> - if (rtd->dev_registered) {
> - /* we don't need to call kfree() for rtd->dev */
>
> Morimoto-san,
>
> I think it is useful to keep this comment when you move soc_rtd_free() to soc_free_pcm_runtime().
Yeah, indeed.
In my mind, the comment /* soc_release_rtd_dev */ was almost for it.
But, yes, Let's keep above comment too.
will fix in v2
> + if (rtd->dev)
> + device_unregister(rtd->dev); /* soc_release_rtd_dev */
More information about the Alsa-devel
mailing list