[alsa-devel] [PATCH 2/2] ALSA: firewire-tascam: check intermediate state of clock status and retry

Takashi Iwai tiwai at suse.de
Tue Sep 10 16:17:40 CEST 2019


On Tue, 10 Sep 2019 15:51:52 +0200,
Takashi Sakamoto wrote:
> 
> 2 bytes in MSB of register for clock status is zero during intermediate
> state after changing status of sampling clock in models of TASCAM FireWire
> series. The duration of this state differs depending on cases. During the
> state, it's better to retry reading the register for current status of
> the clock.
> 
> In current implementation, the intermediate state is checked only when
> getting current sampling transmission frequency, then retry reading.
> This care is required for the other operations to read the register.
> 
> This commit moves the codes of check and retry into helper function
> commonly used for operations to read the register.
> 
> Fixes: e453df44f0d6 ("ALSA: firewire-tascam: add PCM functionality")
> Cc: <stable at vger.kernel.org> # v4.4+
> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>

Applied, thanks.


Takashi


More information about the Alsa-devel mailing list