[alsa-devel] [PATCH v7 6/9] ASoC: Intel: bxt-da7219-max98357a: common hdmi codec support

[Kai Vehmanen]

Hi,

thanks for the review!

On Mon, 28 Oct 2019, Takashi Iwai wrote:

> On Wed, 23 Oct 2019 11:03:28 +0200,
> Kai Vehmanen wrote:
> > -snd-soc-sst-bxt-da7219_max98357a-objs := bxt_da7219_max98357a.o
> > +snd-soc-sst-bxt-da7219_max98357a-objs := bxt_da7219_max98357a.o hda_dsp_common.o
> 
> Hrm, this can be a problem.  I see there are multiple drivers that are
> built with this object.  When they are built as modules and more than
> one module get loaded on a system, it'll lead to a conflict because
> both modules try to put the same stuff.
[...]
> But I'm not entirely sure whether this is true on the recent kernel
> build.  At least it *was* a problem in the past.
> 
> In anyway, please try to load the two modules on your system and check
> whether the module loading works.

hmm, did a quick test and no problems seen, all modules load fine.

Another option is to go back to solution in v6 of the series and
have the helper functions inlines. But it seems v7 works as well, so maybe 
we'll stick with this.

Br, Kai