[alsa-devel] [PATCH] Revert "ALSA: hda: Flush interrupts on disabling"

[Takashi Iwai]

On Mon, 28 Oct 2019 09:21:07 +0100,
Chris Wilson wrote:
> 
> Quoting Takashi Iwai (2019-10-28 08:10:56)
> > This reverts commit caa8422d01e983782548648e125fd617cadcec3f.
> > 
> > It turned out that this commit caused a regression at shutdown /
> > reboot, as the synchronize_irq() calls seems blocking the whole
> > shutdown.  Also another part of the change about shuffling the call
> > order looks suspicious; the azx_stop_chip() call disables the CORB /
> > RIRB while the others may still need the CORB/RIRB update.
> > 
> > Since the original commit itself was a cargo-fix, let's revert the
> > whole patch.
> 
> You will want to include a link to the bug you may be reintroducing so
> you have that information for easy reference later.

Actually I forgot to put the Fixes tag where usually you can track the
original issue from there.  Will fix it.  I don't mind to put yet
another bug link tag, though.

> Also do you know if you fixed the bug in any other way, because our CI
> hasn't reported that GPF since the patch landed.

Well, let's see whether the GPF reappears with the revert at first.
It might be another fix that covered.


thanks,

Takashi