[alsa-devel] [PATCH] ASoC: SOF: Fix memory leak in sof_dfsentry_write

[Pierre-Louis Bossart]

On 10/27/19 2:48 PM, Navid Emamdoost wrote:
> In the implementation of sof_dfsentry_write() memory allocated for
> string is leaked in case of an error. Go to error handling path if the
> d_name.name is not valid.
> 
> Fixes: 091c12e1f50c ("ASoC: SOF: debug: add new debugfs entries for IPC flood test")
> Signed-off-by: Navid Emamdoost <navid.emamdoost at gmail.com>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>

> ---
>   sound/soc/sof/debug.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/sof/debug.c b/sound/soc/sof/debug.c
> index 54cd431faab7..5529e8eeca46 100644
> --- a/sound/soc/sof/debug.c
> +++ b/sound/soc/sof/debug.c
> @@ -152,8 +152,10 @@ static ssize_t sof_dfsentry_write(struct file *file, const char __user *buffer,
>   	 */
>   	dentry = file->f_path.dentry;
>   	if (strcmp(dentry->d_name.name, "ipc_flood_count") &&
> -	    strcmp(dentry->d_name.name, "ipc_flood_duration_ms"))
> -		return -EINVAL;
> +	    strcmp(dentry->d_name.name, "ipc_flood_duration_ms")) {
> +		ret = -EINVAL;
> +		goto out;
> +	}
>   
>   	if (!strcmp(dentry->d_name.name, "ipc_flood_duration_ms"))
>   		flood_duration_test = true;
>