[alsa-devel] [PATCH] ALSA: usb-audio: Add Gustard U16/X26 device family to quirks for native DSD support

Takashi Iwai tiwai at suse.de
Wed Oct 23 07:04:38 CEST 2019


On Wed, 23 Oct 2019 06:05:08 +0200,
Fly Pig wrote:
> 
> Hi There
> 
> This patch add native DSD support for Gustard U16/X26 USB Interface. Tested on
> my unit, working properly. Hence submit the patch. 
> 
> Cheers. 
> 
> Thank you very much.
> 
> Pig

The upstream code changed the DSD detection recently, so your patch
doesn't apply.  In short, check whether you get fp->dsd_raw set.  If
yes, we can apply the vendor check instead of vendor:device pair
check.

Please resubmit the patch with the correction, and don't forget to add
your sign-off line (see Documentation/process/submitting-patches.rst).
It's a legal requirement for taking the patch to upstream.


thanks,

Takashi

> 
> --- a/sound/usb/quirks.c 2019-09-22 21:28:09.757897000 +0000
> +++ b/sound/usb/quirks.c 2019-09-22 21:33:36.892274800 +0000
> @@ -1369,6 +1369,7 @@
>   case USB_ID(0x22d9, 0x0461): /* OPPO UDP-205 */
>   case USB_ID(0x2522, 0x0012): /* LH Labs VI DAC Infinity */
>   case USB_ID(0x2772, 0x0230): /* Pro-Ject Pre Box S2 Digital */
> +        case USB_ID(0x292b, 0xc4b3): /* Gustard U16 */
>   if (fp->altsetting == 2)
>   return SNDRV_PCM_FMTBIT_DSD_U32_BE;
>   break;
> 
> 


More information about the Alsa-devel mailing list