[alsa-devel] [PATCH] ASoC: tas2562: Fix misuse of GENMASK macro
Rikard Falkeborn
rikard.falkeborn at gmail.com
Tue Oct 15 22:09:00 CEST 2019
Arguments are supposed to be ordered high then low.
Fixes: c173dba44c2d ("ASoC: tas2562: Introduce the TAS2562 amplifier")
Signed-off-by: Rikard Falkeborn <rikard.falkeborn at gmail.com>
---
Spotted when trying to introduce compile time checking that the order
of the arguments to GENMASK are correct [0]. I have only compile tested
the patch.
[0]: https://lore.kernel.org/lkml/20191009214502.637875-1-rikard.falkeborn@gmail.com/
sound/soc/codecs/tas2562.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tas2562.h b/sound/soc/codecs/tas2562.h
index 60f2bb1d198b..62e659ab786d 100644
--- a/sound/soc/codecs/tas2562.h
+++ b/sound/soc/codecs/tas2562.h
@@ -62,7 +62,7 @@
#define TAS2562_TDM_CFG2_RIGHT_JUSTIFY BIT(6)
-#define TAS2562_TDM_CFG2_RXLEN_MASK GENMASK(0, 1)
+#define TAS2562_TDM_CFG2_RXLEN_MASK GENMASK(1, 0)
#define TAS2562_TDM_CFG2_RXLEN_16B 0x0
#define TAS2562_TDM_CFG2_RXLEN_24B BIT(0)
#define TAS2562_TDM_CFG2_RXLEN_32B BIT(1)
--
2.23.0
More information about the Alsa-devel
mailing list