[alsa-devel] [PATCH] ASoC: sof: include types.h at header.h

[Daniel Baluta]

On Wed, Oct 16, 2019 at 2:21 PM Mark Brown <broonie at kernel.org> wrote:
>
> On Wed, Oct 16, 2019 at 02:11:57PM +0300, Daniel Baluta wrote:
>
> > That means Mark needs to drop Morimoto-san's patch.
>
> Please send a patch reverting it if you think that's the best option.

On a second thought header.h from FW side includes <stdint.h> so I
think it is fair that header.h from Linux kernel
to include <types.h>

Another remark I have is that usually kernel headers should include
their <uapi> counterparts, but in header.h
doesn't happen. I wonder why.

In my opinion the best solution would be this:

diff --git a/include/sound/sof/header.h b/include/sound/sof/header.h
index 10f00c08dbb7..a0d6b5896467 100644
--- a/include/sound/sof/header.h
+++ b/include/sound/sof/header.h
@@ -9,6 +9,7 @@
 #ifndef __INCLUDE_SOUND_SOF_HEADER_H__
 #define __INCLUDE_SOUND_SOF_HEADER_H__

+#include <uapi/sound/sof/header.h>
 #include <uapi/sound/sof/abi.h>

 /** \addtogroup sof_uapi uAPI

I need Pierre to have a look.