[alsa-devel] [PATCH] ASoC: pcm3168a: Use fixup instead of constraint for channels and formats

[Peter Ujfalusi]

Hi Morimoto-san,

On 15/10/2019 5.38, Kuninori Morimoto wrote:
> 
> Hi Peter
> 
>> The snd_pcm_hw_constraint_minmax() works fine when a single codec is
>> connected to a single CPU DAI, but in multicodec or DPCM setup the
>> constraints placed by the driver will apply to the whole PCM stream (FE
>> included) and thus prevents more than 8 playback channels for example.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi at ti.com>
>> ---
> 
> This patch breaks my sound.
> I'm selecting I2S between CPU<->Codec, and 
> before this patch, it had been selected 24bit + I2S.
> But after this patch, it selects 16bit + I2S,
> and say "16-bit slots are supported only for slave mode using right justified"

Oops. I have sent a patch to fix this. Sorry for the inconvenience!

FWIW, I'm running one pcm3168a in CBS_CFS | RIGHT_J with parallel
serializers (to one McASP) and other two also in CBS_CFS | RIGHT_J
connected to a single McASP in parallel (so I can play 16 channel audio
using the two).

> I'm not 100% understand pcm3168a.
> I'm happy if you can solve this issue.
> If you can't, can you please teach me where should I check ?

Just sent a patch to fix the issue you are seeing with I2S mode (tested
it myself).

Sorry again.

> Thank you for your help !!
> Best regards
> ---
> Kuninori Morimoto
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki