[alsa-devel] [PATCH] ASoC: sof: include types.h at header.h

[Daniel Baluta]

Hello Morimoto-san,

On Tue, Oct 15, 2019 at 8:45 AM Kuninori Morimoto
<kuninori.morimoto.gx at renesas.com> wrote:
>
> Content-Transfer-Encoding: 8bit
>
> Without <types.h> we will get these error
>
> linux/include/sound/sof/header.h:125:2: error: unknown type name ‘uint32_t’uint32_t size;
> linux/include/sound/sof/header.h:136:2: error: unknown type name ‘uint32_t’uint32_t size;
> linux/include/sound/sof/header.h:137:2: error: unknown type name ‘uint32_t’uint32_t cmd;
> ...
> linux/include/sound/sof/dai-imx.h:18:2: error: unknown type name ‘uint16_t’uint16_t reserved1;
> linux/include/sound/sof/dai-imx.h:30:2: error: unknown type name ‘uint16_t’uint16_t tdm_slot_width;
> linux/include/sound/sof/dai-imx.h:31:2: error: unknown type name ‘uint16_t’uint16_t reserved2;
>

I think your patch is OK, but you should update the commit message because
Stephen Rothwell already fixed dai-imx.h compilation error  in linux-next.

> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> ---
>  include/sound/sof/header.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/sound/sof/header.h b/include/sound/sof/header.h
> index 10f00c0..332143f 100644
> --- a/include/sound/sof/header.h
> +++ b/include/sound/sof/header.h
> @@ -9,6 +9,7 @@
>  #ifndef __INCLUDE_SOUND_SOF_HEADER_H__
>  #define __INCLUDE_SOUND_SOF_HEADER_H__
>
> +#include <linux/types.h>
>  #include <uapi/sound/sof/abi.h>
>
>  /** \addtogroup sof_uapi uAPI
> --
> 2.7.4
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel