[alsa-devel] [PATCH v2 18/22] ASoC: soc-core: have legacy_dai_naming at snd_soc_register_dai()
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Tue Oct 15 06:00:47 CEST 2019
From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
ALSA SoC has 2 functions.
snd_soc_register_dai() is used from topology
snd_soc_register_dais() is used from snd_soc_add_component()
In general, people think like _dai() is called from _dais()
with for loop. But in reality, these are very similar
but different implementation.
We shouldn't have duplicated and confusing implementation.
snd_soc_register_dai() is now used from topology.
But to reduce duplicated code, it should be used from _dais(), too.
To prepare it, this patch adds missing parameter legacy_dai_naming
to snd_soc_register_dai().
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
---
v1 -> v2
- tidyup log
include/sound/soc.h | 3 ++-
sound/soc/soc-core.c | 5 +++--
sound/soc/soc-topology.c | 2 +-
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/include/sound/soc.h b/include/sound/soc.h
index daa0e10..766fa81 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -1327,7 +1327,8 @@ struct snd_soc_dai_link *snd_soc_find_dai_link(struct snd_soc_card *card,
const char *stream_name);
int snd_soc_register_dai(struct snd_soc_component *component,
- struct snd_soc_dai_driver *dai_drv);
+ struct snd_soc_dai_driver *dai_drv,
+ bool legacy_dai_naming);
void snd_soc_unregister_dai(struct snd_soc_dai *dai);
struct snd_soc_dai *snd_soc_find_dai(
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 2b9dc11..7bd38fb 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -2607,7 +2607,8 @@ EXPORT_SYMBOL_GPL(snd_soc_unregister_dai);
* will be freed in the component cleanup.
*/
int snd_soc_register_dai(struct snd_soc_component *component,
- struct snd_soc_dai_driver *dai_drv)
+ struct snd_soc_dai_driver *dai_drv,
+ bool legacy_dai_naming)
{
struct snd_soc_dapm_context *dapm =
snd_soc_component_get_dapm(component);
@@ -2621,7 +2622,7 @@ int snd_soc_register_dai(struct snd_soc_component *component,
}
lockdep_assert_held(&client_mutex);
- dai = soc_add_dai(component, dai_drv, false);
+ dai = soc_add_dai(component, dai_drv, legacy_dai_naming);
if (!dai)
return -ENOMEM;
diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c
index 0fd0329..b6e1456 100644
--- a/sound/soc/soc-topology.c
+++ b/sound/soc/soc-topology.c
@@ -1842,7 +1842,7 @@ static int soc_tplg_dai_create(struct soc_tplg *tplg,
list_add(&dai_drv->dobj.list, &tplg->comp->dobj_list);
/* register the DAI to the component */
- return snd_soc_register_dai(tplg->comp, dai_drv);
+ return snd_soc_register_dai(tplg->comp, dai_drv, false);
}
static void set_link_flags(struct snd_soc_dai_link *link,
--
2.7.4
More information about the Alsa-devel
mailing list