[alsa-devel] [PATCH 09/21] ASoC: soc-core: remove unneeded snd_soc_tplg_component_remove()

[Pierre-Louis Bossart]

On 10/8/19 11:30 PM, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> 
> snd_soc_tplg_component_remove() is topology related cleanup function.
> The driver which added topology needed cleanup it, not by soc-core.
> Only topology user skl-pcm is calling it, there is no effect by
> this patch.

the SOF driver also calls snd_soc_tplg_component_remove(), so not sure 
what you meant by the comment?

> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> ---
>   sound/soc/soc-core.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 283ac63..fa837c0 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -2870,8 +2870,6 @@ static int __snd_soc_unregister_component(struct device *dev)
>   		if (dev != component->dev)
>   			continue;
>   
> -		snd_soc_tplg_component_remove(component,
> -					      SND_SOC_TPLG_INDEX_ALL);
>   		snd_soc_component_del_unlocked(component);
>   		found = 1;
>   		break;
>