[alsa-devel] [PATCH 1/6] ASoC: soc-core: use devm_kzalloc() for rtd

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Oct 3 02:31:33 CEST 2019


Hi Mark

> > From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> 
> > Current rtd, rtd->dev, rtd->codec_dais are created by normal kzalloc(),
> > but we want to use devm_kzalloc() as much as possible.
> > 
> > Created rtd->dev is registered by device_register() at
> > soc_new_pcm_runtime(), and it will be freed at
> > soc_free_pcm_runtime() by device_unregister().
> 
> These aren't using devm_ because they are done at card init time and so
> might happen multiple times when other card components get removed and
> added.  This shouldn't happen too much but if it does then it could end
> up consuming a noticeable amount of memory.

I see.
Actually my local patch which is not yet posted can solve this
multiple times issue.
Mergeing these can be good solution.
Please drop it so far.

Thank you for your help !!
Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list