[alsa-devel] [PATCH 5/6] ASoC: soc-core: setup card->rtd_num at snd_soc_instantiate_card()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Wed Oct 2 09:59:10 CEST 2019


Hi Daniel

Thank you for your feedback

> > @@ -2008,6 +2006,7 @@ static int snd_soc_instantiate_card(struct snd_soc_card *card)
> >                 goto probe_end;
> >
> >         /* add predefined DAI links to the list */
> > +       card->num_rtd = 0;
> 
> Shouldn't this be placed before the comment above?
> 
> >         for_each_card_prelinks(card, i, dai_link) {
> >                 ret = snd_soc_add_dai_link(card, dai_link);
> >                 if (ret < 0)

It is used under this for_each_card_prelinks() loop.
card->num_rtd setup and this loop are 1 set.
Thus, I added it under comment.

Thank you for your help !!
Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list