[alsa-devel] [PATCH] ALSA: hda: hdmi - fix regression in connect list handling

Kai Vehmanen kai.vehmanen at linux.intel.com
Wed Nov 27 12:30:50 CET 2019


Hi Takashi and Nikhil,

On Wed, 27 Nov 2019, Kai Vehmanen wrote:

> Fix regression in how intel_haswell_fixup_connect_list()
> results are used in hda_read_pin_conn(). Use of
> snd_hda_get_raw_connections() in hda_read_pin_conn() bypasses
> the cache and thus also bypasses the overridden pin connection

the original series did pass our SOF CI, but as we have now results from 
wider testing, it unfortunately seems a regression slipped through.
Re-reviewing the code, this bit seems clearly wrong, we can't use
get_raw_connections() if we depend on the connection overrides.

This patch should not affect non-Intel platforms, but please review
in any case.

Br, Kai


More information about the Alsa-devel mailing list