[alsa-devel] [PATCH v2 1/2] ASoC: improve the DMI long card code in asoc-core

[Jaroslav Kysela]

Dne 21. 11. 19 v 12:51 Mark Brown napsal(a):
> On Wed, Nov 20, 2019 at 06:44:34PM +0100, Jaroslav Kysela wrote:
> 
>> -	/* make up dmi long name as: vendor.product.version.board */
>> +	/* make up dmi long name as: vendor-product-version-board */
> 
> I'm worried about this from an ABI point of view with people's UCM
> files.  But perhaps I'm worrying about nothing?

Mark,

   this is just the C comment fix. The long name is already in
vendor-product-version-board - no dots as delimiters (but does are allowed in 
the fields like version strings). This code improvement does not change the 
format of the generated long name string from the DMI information.

   Just see the examples in the soc-core.c comment for snd_soc_set_dmi_name():

  * Possible card long names may be:
  * DellInc.-XPS139343-01-0310JH
  * ASUSTeKCOMPUTERINC.-T100TA-1.0-T100TA
  * Circuitco-MinnowboardMaxD0PLATFORM-D0-MinnowBoardMAX

						Jaroslav

-- 
Jaroslav Kysela <perex at perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.