[alsa-devel] [PATCH 0/2] ASoC: fixup topology dai_link remove issue

[Pierre-Louis Bossart]

On 11/18/19 7:10 PM, Kuninori Morimoto wrote:
> 
> Hi Pierre-Louis
> 
>>> These are already tested by Intel CI, and all issues were solved.
>>> (https://github.com/thesofproject/linux/pull/1504)
>>> Extra Tested-by / Reviewed-by are very welcome from Intel
>>
>> if you don't mind I'd like to retest this new series, it's based on a
>> different tip and is not exactly the same as before.
> 
> Yes, of course.
> Sorry I didn't mention about it.
> 
>> -	/* free the ALSA card at first; this syncs with pending operations */
>> -	if (card->snd_card) {
>> -		snd_card_free(card->snd_card);
>> -		card->snd_card = NULL;
>> -	}
>> +	if (card->snd_card)
>> +		snd_card_disconnect_sync(card->snd_card);
>>
>>   	snd_soc_dapm_shutdown(card); <<< not tested yet.
>>
>>   	/* remove and free each DAI */
>>   	soc_remove_link_dais(card);
>> +	soc_remove_link_components(card);
> 
> Yes.
> It is from
> 
> 2a6f0892bda954dc2688b002060093ee0fe38528
> ("ASoC: soc-core: call snd_soc_dapm_shutdown() at soc_cleanup_card_resources()")

No regression detected so from the Intel side we're good with this patchset.
Thanks Morimoto-san for this comprehensive analysis, really nice work!