[alsa-devel] [PATCH v10 1/6] ASoC: amd:Create multiple I2S platform device endpoint

Dan Carpenter dan.carpenter at oracle.com
Tue Nov 19 15:16:28 CET 2019


On Tue, Nov 19, 2019 at 07:38:23PM +0530, Ravulapati Vishnu vardhan rao wrote:
> @@ -56,10 +56,11 @@ static int snd_acp3x_probe(struct pci_dev *pci,
>  		irqflags = 0;
>  
>  	addr = pci_resource_start(pci, 0);
> -	adata->acp3x_base = ioremap(addr, pci_resource_len(pci, 0));
> +	adata->acp3x_base = devm_ioremap(&pci->dev, addr,
> +					pci_resource_len(pci, 0));
>  	if (!adata->acp3x_base) {
>  		ret = -ENOMEM;
> -		goto release_regions;
> +		goto disable_msi;

This is a bug fix.  :)

>  	}
>  	pci_set_master(pci);
>  	pci_set_drvdata(pci, adata);

This patch is fine.

Reviewed-by: Dan Carpenter <dan.carpenter at oracle.com>

regards,
dan carpenter



More information about the Alsa-devel mailing list