[alsa-devel] [PATCH alsa-lib 1/4] ucm: Fix opening of master-configs by the card's longname

[Jaroslav Kysela]

Dne 19. 11. 19 v 11:48 Hans de Goede napsal(a):
> Prior to commit aba2260ae7b5 ("ucm: switch to ucm2 directory and v2 format,
> keep backward compatibility").
> 
> The filename build in parse_verb_file() was build like this:
> <prefix>/<uc_mgr->conf_file_name>/<file>
> 
> Where uc_mgr->conf_file_name would contain either the card_name or the
> card's longname depending on the detection of a longname based config in
> uc_mgr_import_master_config().
> 
> While the filename used in load_master_config() was build like this:
> <prefix>/<card_name>/<card_name>.conf
> 
> And uc_mgr_import_master_config() first calls load_master_config()
> with the card's longname and if that succeeds it overwrites
> uc_mgr->conf_file_name with the longname so that the subsequent uses
> of uc_mgr->conf_file_name in parse_verb_file() correctly use the longname.
> 
> But the new configuration_filename() helper added in commit aba2260ae7b5
> _always_ builds the filename like this:
> <prefix>/<uc_mgr->conf_file_name>/<file><suffix>
> 
> This breaks the loading of the master-config by its longname, as when
> the longname is tried uc_mgr->conf_file_name still contains the card_name.

Hi Hans,

This new behaviour was intended for ucm2. I applied all four your patches, and 
added 10a63e093c4a98acfa9bcdfdd06938bcd874b008 on top which should keep the
new behaviour for v2 configs.

It's time to create the 1.2.1.1 bugfix alsa-lib release, I guess.

			Thank you,
				Jaroslav

-- 
Jaroslav Kysela <perex at perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.