[alsa-devel] [PATCH v1 2/5] ALSA: hda - Add DP-MST jack support

Kai Vehmanen kai.vehmanen at linux.intel.com
Thu Nov 14 11:46:34 CET 2019


Hi Nikhil,

On Thu, 14 Nov 2019, Nikhil Mahale wrote:

> This patch adds DP-MST jack support which will be used on NVIDIA
> platforms. Today, DP-MST audio is supported only if the codec has
> acomp support. This patch makes it possible to add DP-MST support
> for non-acomp codecs.
[...]
> +++ b/sound/pci/hda/hda_generic.c
> @@ -4203,7 +4203,7 @@ static bool detect_pin_state(struct hda_codec *codec, hda_nid_t pin)
>  {
>  	if (!is_jack_detectable(codec, pin))
>  		return true;
> -	return snd_hda_jack_detect_state(codec, pin) != HDA_JACK_NOT_PRESENT;
> +	return snd_hda_jack_detect_state(codec, pin, 0) != HDA_JACK_NOT_PRESENT;
>  }

the patch adds quite a few checkpatch warnings. E.g. this line over 
80 character limit. Run checkpatch yourself or take a look at e.g.
https://travis-ci.org/thesofproject/linux/jobs/611787177?utm_medium=notification&utm_source=github_status

I'll queued the series to SOF CI to do some testing against regressions 
on our platforms. I'll report later if anything major found.

Br, Kai


More information about the Alsa-devel mailing list