[alsa-devel] [RESEND PATCH v4 1/6] ASoC: amd:Create multiple I2S platform device Endpoint

[RAVULAPATI, VISHNU VARDHAN RAO]

Get Outlook for Android<https://aka.ms/ghei36>



From: Pierre-Louis Bossart
Sent: Monday, 11 November, 10:11 PM
Subject: Re: [alsa-devel] [RESEND PATCH v4 1/6] ASoC: amd:Create multiple I2S platform device Endpoint
To: RAVULAPATI, VISHNU VARDHAN RAO
Cc: moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..., Maruthi Srinivas Bayyavarapu, open list, Takashi Iwai, Liam Girdwood, Agrawal, Akshu, Mark Brown, djkurtz at google.com, Mukunda, Vijendar, Deucher, Alexander, Colin Ian King, Dan Carpenter



> +             pdevinfo[2].name = "acp3x_i2s_playcap";
> +             pdevinfo[2].id = 1;
> +             pdevinfo[2].parent = &pci->dev;
> +             pdevinfo[2].num_res = 1;
> +             pdevinfo[2].res = &adata->res[2];
> +             for (i = 0; i < ACP3x_DEVS ; i++) {
> +                     adata->pdev[i] =
> +                             platform_device_register_full(&pdevinfo[i]);
> +                     IS_ERR(adata->pdev[i]) {

how does this even compile?

I have not faced any issue of compilation.
Can I know what is wrong with it please so that it can be re checked.

> +                             dev_err(&pci->dev, "cannot register %s device\n",
> +                                     pdevinfo[i].name);
> +                             ret = -ENODEV;
> +                             goto unmap_mmio;
> +                     }