[alsa-devel] [PATCH v2 2/8] ALSA: aloop: loopback_timer_start: Support return of error code

Takashi Iwai tiwai at suse.de
Wed Nov 6 16:50:32 CET 2019


On Tue, 05 Nov 2019 15:32:12 +0100,
Andrew Gabbasov wrote:
> 
> @@ -264,7 +266,7 @@ static int loopback_trigger(struct snd_pcm_substream *substream, int cmd)
>  		spin_lock(&cable->lock);	
>  		cable->running |= stream;
>  		cable->pause &= ~stream;
> -		loopback_timer_start(dpcm);
> +		err = loopback_timer_start(dpcm);
>  		spin_unlock(&cable->lock);
>  		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
>  			loopback_active_notify(dpcm);

Will we notify even if the start/stop fails?


thanks,

Takashi


More information about the Alsa-devel mailing list