[alsa-devel] [PATCH v2] ASoC: max98373: replace gpio_request with devm_gpio_request

Kai Vehmanen kai.vehmanen at linux.intel.com
Tue Nov 5 15:23:37 CET 2019


Hi,

On Mon, 4 Nov 2019, Yong Zhi wrote:

> Use devm_gpio_request() to automatic unroll when fails and avoid
> resource leaks at error paths.

this is a bugfix still, so maybe reword as:

Fix resource leaks on error paths by using devm_gpio_request().

> Signed-off-by: Yong Zhi <yong.zhi at intel.com>
> ---
> v2 change:
> - use devm_gpio_request to avoid the goto statement based on review comments.

All in all, looks good, move to devm_ is even better!

Br, Kai


More information about the Alsa-devel mailing list