[alsa-devel] [PATCH v2 resend 01/18] ASoC: soc-core: remove unneeded snd_soc_tplg_component_remove()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Tue Nov 5 05:02:52 CET 2019


Hi Sridharan

Thank you for your feedback

>     From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
>    
>     snd_soc_tplg_component_remove() is pair of snd_soc_tplg_component_load(),
>     and it is topology related cleanup function.
>    
>     The driver which called _load() needs to call _remove() by its responsibility.
>     Today, skl-pcm and topology are the user, and these are calling both
>     _load() and _remove().
>    
>     soc-core doesn't need to call it.
>     This patch remove it.
(snip)
> When I submitted changes for fixing module load/unload errors with SOF, I had a patch that added this change. At that time,
> Mark commented that this can be left as is to make the unregister_component() robust.
> 
> Mark, do you still think it should be left as is or are you OK to remove this?

This is already accepted by

	e9904ed5e73af4fd00cf4fcf705420a385af45da
	("ASoC: soc-core: remove unneeded snd_soc_tplg_component_remove()")

But, I'm OK to keep/reborn it as "robust".
Then, I want to have comment, like below.
Otherwise, it is confusable for non-topology user.

	/* For framework level robustness */
	snd_soc_tplg_component_remove(...)


Thank you for your help !!
Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list