[alsa-devel] [PATCH 10/14] soundwire: intel: add prepare support in sdw dai driver

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Mon Nov 4 22:31:16 CET 2019



On 11/4/19 1:45 PM, Cezary Rojewski wrote:
> On 2019-10-23 23:28, Pierre-Louis Bossart wrote:
>> From: Rander Wang <rander.wang at linux.intel.com>
>>
>> It gets sdw runtime information from dai to prepare stream.
>>
>> Signed-off-by: Rander Wang <rander.wang at linux.intel.com>
>> Signed-off-by: Pierre-Louis Bossart 
>> <pierre-louis.bossart at linux.intel.com>
> 
> While the patch looks good, the commit message is questionable. You may 
> simply state why it is added only just now. Judging from the commit 
> title, it has been added to make the sdw dai driver interface complete.

The commit message is not great but it's not wrong either...


More information about the Alsa-devel mailing list