[alsa-devel] [PATCH] ASoC: max98373: Fix calls to free_gpio()

Kai Vehmanen kai.vehmanen at linux.intel.com
Mon Nov 4 11:27:30 CET 2019


Hi,

On Fri, 1 Nov 2019, Yong Zhi wrote:

> Don't Call free_gpio() when request_gpio() fails, call it
> at error paths to avoid resource leak.

patch looks good to me:

Reviewed-by: Kai Vehmanen <kai.vehmanen at linux.intel.com>

PS This is good as a clear bugfix. For future, use of
   devm_gpiod_get_*() and friends is recommended.


More information about the Alsa-devel mailing list