[alsa-devel] [PATCH 1/3] ASoC: Intel: sof-rt5682: Few minor fixes for AMP SSP and codec button

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Mon May 20 15:39:24 CEST 2019



On 5/20/19 7:31 AM, Mark Brown wrote:
> On Sat, May 18, 2019 at 01:30:07PM -0500, Pierre-Louis Bossart wrote:
>> From: Sathya Prakash M R <sathya.prakash.m.r at intel.com>
>>
>>      This fixes:
>>      1. BIT mask for AMP SSP was incorrect.
>>      2. The RT5682 codec button mapping is corrected.
> 
> Indentation is a bit weird here, and these are really two changes that
> should be split.
> 
>> @@ -519,6 +520,7 @@ static int sof_audio_probe(struct platform_device *pdev)
>>   
>>   	/* compute number of dai links */
>>   	sof_audio_card_rt5682.num_links = 1 + dmic_num + hdmi_num;
>> +
>>   	if (sof_rt5682_quirk & SOF_SPEAKER_AMP_PRESENT)
>>   		sof_audio_card_rt5682.num_links++;
>>   
> 
> and this is an unrelated indentation change.

ok, I'll send a v2.


More information about the Alsa-devel mailing list