[alsa-devel] [PATCH 11/12] ALSA: hdac: fix memory release for SST and SOF drivers

[Takashi Iwai]

On Sun, 19 May 2019 09:30:03 +0200,
Takashi Iwai wrote:
> 
> On Sat, 18 May 2019 22:27:03 +0200,
> Pierre-Louis Bossart wrote:
> > 
> > From: Amadeusz Sławiński <amadeuszx.slawinski at linux.intel.com>
> > 
> > During the integration of HDaudio support, we changed the way in which
> > we get hdev in snd_hdac_ext_bus_device_init() to use one preallocated
> > with devm_kzalloc(), however it still left kfree(hdev) in
> > snd_hdac_ext_bus_device_exit(). It leads to oopses when trying to
> > rmmod and modprobe. Fix it, by just removing kfree call.
> > 
> > SOF also uses some of the snd_hdac_ functions for HDAudio support but
> > allocated the memory with kzalloc. A matching fix is provided
> > separately to align all users of the snd_hdac_ library.
> > 
> > Fixes: 6298542fa33b ("ALSA: hdac: remove memory allocation from snd_hdac_ext_bus_device_init")
> > Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski at linux.intel.com>
> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
> 
> Since this is an individual fix from SOF, I'll take this one via my
> tree.

On the second thought: as the other two patches seem depending on this 
change as prerequisite, maybe better to leave this together with
others.  So, Mark feel free to take this with the series, but make
sure that they'll go to 5.2-rc.


thanks,

Takashi